feat: Support removing properties from catalogs#713
Conversation
|
Is there any known negative consequence to doing this? |
I'm not aware of any. Trino is a bit special than other tools as it refuses to start up for any unneeded property |
|
It feels weird to have this "seem" so unrelated to apiVersion: trino.stackable.tech/v1alpha1
kind: TrinoCatalog
spec:
connector:
hive: {}
configOverrides:
hive.metastore.username: trino
property.which.blocks.trino.startup: null # <<< removes fieldAnother option would be to follow your proposal for v1alpha1, but switch to something like this in v1alpha2: apiVersion: trino.stackable.tech/v1alpha2
kind: TrinoCatalog
spec:
connector:
hive: {}
configOverrides:
set: # <<< was configOverrides
hive.metastore.username: trino
remove: # <<< was experimentalConfigRemovals
- property.which.blocks.trino.startup |
|
Yeah, exactly
IMHO we need this solution for all operators, which is a big task I don't want to do right now. |
|
Moving this to Voting, please vote on this comment |
|
Decision accepted in planning |
maltesander
left a comment
There was a problem hiding this comment.
Currently the worker fail their probes
Warning Unhealthy 4m45s (x5 over 28m) kubelet Readiness probe failed: Get "https://10.244.0.22:8443/v1/info": dial tcp 10.244.0.22:8443: connect: connection refused
Warning Unhealthy 4m45s (x2 over 28m) kubelet Liveness probe failed: Get "https://10.244.0.22:8443/v1/info": unexpected EOF
Warning Unhealthy 4m45s kubelet Readiness probe failed: Get "https://10.244.0.22:8443/v1/info": unexpected EOF
``
Co-authored-by: Malte Sander <malte.sander.it@gmail.com>
|
Please add a link to the docs and a release note snippet. |
|
Docs: https://docs.stackable.tech/home/nightly/trino/usage-guide/catalogs/#_config_overrides_and_config_removals Lines 15 to 16 in c3a86db |
Description
Part of #712.
I was also running into this in the past, so a nice quality of life feature.
Adds a new field, see added docs for details:
Definition of Done Checklist